Skip to content

Adding test reproducing the compiler crash reported in #7965 #7968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

dkarlinsky
Copy link

Tor run, under sbt:

testOnly *.CompilationTests -- --tests=compilerCrash

Copy link
Member

@dottybot dottybot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, and thank you for opening this PR! 🎉

All contributors have signed the CLA, thank you! ❤️

Have an awesome day! ☀️

@@ -284,6 +284,13 @@ class CompilationTests extends ParallelTesting {
implicit val testGroup: TestGroup = TestGroup("explicitNullsRun")
compileFilesInDir("tests/explicit-nulls/run", explicitNullsOptions)
}.checkRuns()

@Test def compilerCrash: Unit = {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is test duplication, if you put the test file in tests/pos/7965.scala then it will be tested exactly the same by pos in CompilationTests, you can then run it exclusively with sbt testCompilation tests/pos/7965.scala. http://dotty.epfl.ch/docs/contributing/testing.html

This test case can only be accepted in a PR if it actually passes the test. If the intention is to include code in the repository to prove the failure to compile then the example being documented in the issue is enough for someone to begin a fix.

@bishabosha
Copy link
Member

Hi, thank you for submitting this PR, if you intend to work on a fix, please may you append "WIP" to the title, or else we will have to close it as we can't accept failing tests

@dkarlinsky
Copy link
Author

@bishabosha I would love to be able to fix this, but I wouldn't know where to start
Unless someone can point me in the right direction...
My hope for this PR was that it would save some work for whoever works on this.
But again, if you can give me a direction, I'd be happy to try.

@anatoliykmetyuk
Copy link
Contributor

Thanks for minimizing it @dkarlinsky! Since I see you posted it in the original issue, #7965 (comment), I'll close this PR. Once the fix is available, it is trivial to include the test, see https://github.com/lampepfl/dotty/pull/7968/files#r365714840 comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants